-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: support flat config #81
Conversation
db349e5
to
7b8a80e
Compare
If they work correctly with
Yes.
If the CLI is running in flat config mode, then |
35d0344
to
8e3dfb9
Compare
f4ab4e7
to
ffaa7c9
Compare
@aladdin-add what's the status on this? I'd really like to roll out this change soon, so if you need help, please us know. |
@nzakas I've added the remaining tasks in the PR desc. |
Thanks, and do you need help finishing? As I mentioned, we'd like to get this out ASAP. |
The main blocker is many community plugins/configs do not support it yet. ( I'd like it to be officially supported before we merge this. |
We can't really afford to wait for all plugins to be updated because v9.0.0 is already in beta and it doesn't make sense to have us generating eslintrc files anymore. Can't we just use |
Co-authored-by: Francesco Trotta <[email protected]>
Co-authored-by: Francesco Trotta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! Leaving open for @mdjermanovic to review, as requested.
friendly ping @mdjermanovic |
eslint-plugin-vue has landed the official supports: https://github.com/vuejs/eslint-plugin-vue/releases/tag/v9.24.0 |
Is it intentional that we no longer show the list of dependencies that are going to be installed and ask the user for confirmation to install them? |
yes, it's relying on installing to update the |
I think we should add it back to let the user know what packages are going to be installed and provide a way to generate the config file without installing them (e.g., in case the user is using some package manager that isn't listed). |
I agree, I think showing the dependencies to install before installing them is useful and should be included. |
@mdjermanovic I've pushed a commit: 0a4c547 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Leaving open for @mdjermanovic to verify.
Co-authored-by: Milos Djermanovic <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Implementing flat support is a good opportunity that allows us to rewrite and simplify its implementation. This PR implements an initial version for gathering feedback. There are some challenges and issues:
@eslint/eslintrc
for compatibility?env: node/browser
is no longer supported in flat config. Should we introduce theglobals
package to support this feature?--config
was previously used as a shortcut for using shareable configurations. There seems to be no reliable way to determine if it is in flat format. Can we assume that it is?fixes #51
Remaining tasks:
--config
options🧪for testing